✨ [Frontend] Request services access #7897
Merged
+167
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bba85b1 |
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability for sharees to see which service owners they need to contact for access, and surfaces a “Request Apps Access” dialog in the dashboard when services are inaccessible.
- Introduce a static
checkShareePermissionshelper andShareePermissionswidget for showing blocked sharees. - Add a new
RequestServiceAccesswidget to list app owners and contact info. - Refactor
CollaboratorsStudyto use the new static method and inject a “Request Apps Access” button intoResourceDetails.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/share/ShareePermissions.js | Added static permission check, popup UI, and data-structure docs |
| services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js | New widget displaying app owners, emails, and apps needing access |
| services/static-webserver/client/source/class/osparc/share/CollaboratorsStudy.js | Refactored to use checkShareePermissions instead of inline fetch |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Inject “Request Apps Access” button into toolbar for blocked items |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js:1
- Add unit tests for the RequestServiceAccess widget to verify layout rendering and behavior when provided with various service–access datasets.
/*
services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js:71
- Calling
group.getEmail()may return undefined or an empty string if the email isn't public; add a fallback or placeholder to handle missing emails gracefully.
const email = new qx.ui.basic.Label(group.getEmail()).set({
services/static-webserver/client/source/class/osparc/share/ShareePermissions.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/share/ShareePermissions.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/share/ShareePermissions.js
Show resolved
Hide resolved
pcrespov
approved these changes
Jun 16, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
ok. so next step would be to add a button to notify the owner (when we have the notifications in mplace)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When a project is blocked because the sharee has no access to some of its services, at the moment that user can't do much.
This PR gives the blocked user some information about the service owner. The only thing the frontend gets is the service owner's group id, which leads to his/her public information (username, email, full name). With this the sharee could contact the owner.
Related issue/s
How to test
Dev-ops